feat(InlineLoading): add support for warning status

[janhassel]

This PR adds the option for a warning status to the InlineLoading component.

Changelog

New

• warning status in InlineLoading

Changed

• Changed current error icon to ErrorFilled icon to be consistent with the filled finished state and improve contrast for warning.

[netlify]

Deploy preview for carbon-elements ready!

Built with commit b09ce89

https://deploy-preview-4810--carbon-elements.netlify.com

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit b09ce89

https://deploy-preview-4810--carbon-components-react.netlify.com

[netlify]

Deploy preview for the-carbon-components ready!

Built with commit b09ce89

https://deploy-preview-4810--the-carbon-components.netlify.com

[asudoh]

New UX feature, requires design review.

[janhassel]

@emyarod Oh yeah, right. I was wondering why it wasn't else-if and didn't think about the returns. Thank you!

[joshblack]

Hey @janhassel! Is there a corresponding issue we could look at for this feature?

[aagonzales]

Agreed, should be the filled version.

[asudoh]

LGTM 👍 - Thanks @janhassel!

[janhassel]

@joshblack We haven't opened an issue for this, but I can send you some information about the use case via Slack if you want.

[joshblack]

@janhassel would you mind opening a ticket for it just so we can better understand the use-case/goal for adding it in?

Separately, I think the changes to the error icons and what-not are perfect so it might make sense to get that in with this PR and then do the net-new functionality in a later one once we understand the use-case.

[janhassel]

@joshblack I opened an issue with a sample use case (committing in git): #4835

[joshblack]

Thanks @janhassel!

[joshblack]

Just a quick note, still waiting for another dev review and for the linked issue to be signed off by design 👍 After talking in our support channel it seems like @aagonzales might have only noticed the icon change (which is perfect 💯) and not the additional feature so will wait on them to verify in the linked issue!

[aagonzales]

@janhassel If the user is given the warning does that mean the load was not successful? The example is about merge conflicts but I'm trying to understand what is being recommended for the general guidance of when "warning" would be used instead of a binary success/fail.

[janhassel]

@aagonzales Let's think about another example: a file uploader. We show the user the Inline Loading component while the file is being uploaded, once it's done, we switch to the finished state. If the upload failed, we show the error state.
But if a file with this name already exists on the destination, we can show the user a warning state, telling them that their file has been uploaded but they need to tell us whether or not to overwrite the existing file.

So to sum it up:
success / finished

• everything worked, nothing to do

error

• something didn't work out, the user can not proceed with the aspired action

warning

• it worked, but due to an issue there is an extra step required for the user to accomplish their action
• something didn't work out, but it is not crucial and the user can proceed. The action might be accomplished later on by the system.

[tw15egan]

Looks great on the dev side of things, just need @aagonzales to sign off and we can merge it in 👍

[joshblack]

Any chance we could split this into just the icon change and then the proposal for the behavior? Would love to chat/learn more about the warning use-case and how we can incorporate into docs/guidance 👍

[janhassel]

Definitely, I opened another PR just concerning the icon: #5018

@joshblack I'll send you a detailed example on Slack.

[asudoh]

Any updates @janhassel @joshblack? Thanks!

[aagonzales]

Controversial statement: I think this feature is its own component and not an enhancement to inline loading. It's a status indictor and not solely about the state of loading. Jan explained the scenario to me further and I believe its a valid use-case I'm just not sure it belongs within the inline loading component.

[asudoh]

@aagonzales Would you have a chance to other designer peers and see what we should do with this PR...? Thanks!

[joshblack]

Closing this out in favor of the proposal over in: #4835

Thanks again for talking through this stuff @janhassel!