fix(data-table): use unselectAll translation key if selection checkbox is indeterminate #4570
Conversation
ghost
requested review from
jendowns
changed the title
|
Deploy preview for the-carbon-components ready! Built with commit f069b6f https://deploy-preview-4570--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit f069b6f https://deploy-preview-4570--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit f069b6f |
|
Tested react version. Looks good! Thanks, @jendowns! |
| ? translationKeys.unselectAll | ||
| : translationKeys.selectAll; | ||
| const translationKey = | ||
| checked || indeterminate |
There was a problem hiding this comment.
| checked || indeterminate | |
| (checked || indeterminate) |
Does prettier end up taking away the parenthesis here? There seems to be some syntax ambiguity that adding these in might help with. Otherwise, seems great!
There was a problem hiding this comment.
yeah prettier will remove parentheses there. by default it is evaluated as (checked || indeterminate) ? ... : ... rather than checked || (indeterminate ? ... : ...)
Closes #4556
Changelog
Changed
indeterminatecheckbox (as well ascheckedto determinate iftranslationKeys.unselectAllis usedTesting / Reviewing
Open the
carbon-components-reactdeploy and follow the steps in #4556 -- directly select only a few rows, and then check thearia-labelof the indeterminate icon. It should say "unselect all rows" instead of "select all rows"