Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pictograms): update metadata for milan and mexico-city as… #4102

Merged
merged 4 commits into from
Sep 26, 2019
Merged

chore(pictograms): update metadata for milan and mexico-city as… #4102

merged 4 commits into from
Sep 26, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Sep 26, 2019

No description provided.

@vpicone vpicone requested a review from a team as a code owner September 26, 2019 14:46
@vpicone vpicone requested a review from joshblack September 26, 2019 14:46
@ghost ghost requested a review from dakahn September 26, 2019 14:46
joshblack
joshblack approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update the merge commit to:

chore(pictograms): update metadata for milan and mexico-city assets

@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for the-carbon-components ready!

Built with commit 0497e5f

https://deploy-preview-4102--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for carbon-elements failed.

Built with commit 0497e5f

https://app.netlify.com/sites/carbon-elements/deploys/5d8ccf401e93340008018d4e

@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for carbon-components-react failed.

Built with commit 0497e5f

https://app.netlify.com/sites/carbon-components-react/deploys/5d8ccf4055b1870007e6803b

@netlify
Copy link

netlify bot commented Sep 26, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 70e4d6a

https://deploy-preview-4102--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 26, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 70e4d6a

https://deploy-preview-4102--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for carbon-components-react ready!

Built with commit 3476afa

https://deploy-preview-4102--carbon-components-react.netlify.com

@vpicone vpicone changed the title fix: metadata for Milan and Mexico City chore(pictograms): update metadata for milan and mexico-city assets Sep 26, 2019
@netlify
Copy link

netlify bot commented Sep 26, 2019 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 70e4d6a

https://deploy-preview-4102--carbon-components-react.netlify.com

@vpicone vpicone changed the title chore(pictograms): update metadata for milan and mexico-city assets chore(pictograms): update metadata for milan and mexico-city as… Sep 26, 2019
@vpicone vpicone merged commit 10378d5 into carbon-design-system:master Sep 26, 2019
@vpicone vpicone deleted the metadata-fix branch September 26, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@chrisconnors-ibm chrisconnors-ibm chrisconnors-ibm approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vpicone @joshblack @chrisconnors-ibm @dakahn