Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make pictogram packages public #4098

Merged
merged 5 commits into from
Sep 26, 2019
Merged

chore: make pictogram packages public #4098

merged 5 commits into from
Sep 26, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Sep 25, 2019

closes #4079

@vpicone vpicone requested a review from a team as a code owner September 25, 2019 22:47
@ghost ghost requested review from abbeyhrt and emyarod September 25, 2019 22:47
@vpicone vpicone requested a review from joshblack September 25, 2019 22:47
joshblack
joshblack approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great, excited this is shipping! Only question is around versions and if we wanted to start at 10.0.0 or latest Carbon version (10.6.0)

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for the-carbon-components ready!

Built with commit cb39fe1

https://deploy-preview-4098--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for carbon-elements ready!

Built with commit cb39fe1

https://deploy-preview-4098--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for carbon-components-react failed.

Built with commit cb39fe1

https://app.netlify.com/sites/carbon-components-react/deploys/5d8bee6e69e63d00081841bc

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for the-carbon-components ready!

Built with commit 7becdba

https://deploy-preview-4098--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for the-carbon-components failed.

Built with commit 18ad349

https://app.netlify.com/sites/the-carbon-components/deploys/5d8bf26bbd86f4000779c08e

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for carbon-elements ready!

Built with commit 7becdba

https://deploy-preview-4098--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for carbon-elements failed.

Built with commit 18ad349

https://app.netlify.com/sites/carbon-elements/deploys/5d8bf26b291d9600083cdb7a

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for carbon-components-react ready!

Built with commit 7becdba

https://deploy-preview-4098--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Sep 25, 2019

Deploy preview for carbon-components-react failed.

Built with commit 18ad349

https://app.netlify.com/sites/carbon-components-react/deploys/5d8bf26bd44034000c35437d

@vpicone vpicone merged commit ca4b18e into carbon-design-system:master Sep 26, 2019
@vpicone vpicone deleted the make-pictograms-public branch September 26, 2019 14:53
@jnm2377 jnm2377 mentioned this pull request Sep 30, 2019
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@emyarod emyarod emyarod approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release pictograms packages
4 participants
@vpicone @joshblack @emyarod @abbeyhrt