feat(pictograms): adds pictos and updates categories #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds: mexico--city--angel--of--independence.svg mexico--city--museo--soumaya.svg milan--duomo--di--milano.svg milan--skyscrapers.svg updates categories.yml
ghost
requested review from
jnm2377
reviewed
Sep 19, 2019
packages/pictograms/categories.yml
Outdated
| - mexico--city--angel--of--independence | ||
| - mexico--city--museo--soumaya | ||
| - milan--duomo--di--milano | ||
| - milan--skyscrapers.svg |
There was a problem hiding this comment.
Is there a reason this one includes .svg and the others don't?
|
Also can we update the commit title to use proper commit syntax? Thanks! |
joshblack
suggested changes
Sep 19, 2019
|
Deploy preview for the-carbon-components ready! Built with commit 7c4727c https://deploy-preview-4041--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 7c4727c |
|
Deploy preview for carbon-components-react ready! Built with commit 7c4727c https://deploy-preview-4041--carbon-components-react.netlify.com |
sorry, no PRs in haste! Co-Authored-By: Josh Black <[email protected]>
chrisconnors-ibm
changed the title
jnm2377
approved these changes
Sep 20, 2019
|
hmm... I think the pictograms need to be added to testing maybe? It seems like ci is failing bc it says they're missing. |
joshblack
approved these changes
Sep 20, 2019
joshblack
suggested changes
Sep 20, 2019
|
Bump @chrisconnors-ibm do you have a sec to add in the metadata into |
add items to metadata.yml
corrected the new entries
joshblack
approved these changes
Sep 25, 2019
change delimiter in `mexico--city` to `mexico-city` filenames and categoreis.yml and metadata.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
New
Changed
reviewers
verify svgs exist/work. search against aliases (
museumandstatue). all four grouped withinCities.