Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3D-iCA metadata #3709

Merged
merged 9 commits into from
Aug 26, 2019
Merged

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Aug 10, 2019

closes #3708

@netlify
Copy link

netlify bot commented Aug 10, 2019

Deploy preview for the-carbon-components ready!

Built with commit e333e98

https://deploy-preview-3709--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 10, 2019

Deploy preview for carbon-elements ready!

Built with commit e333e98

https://deploy-preview-3709--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Aug 10, 2019

Deploy preview for carbon-components-react failed.

Built with commit e333e98

https://app.netlify.com/sites/carbon-components-react/deploys/5d64119fe2d9060007c28deb

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will defer to chris/conrad on categorization 👍

@vpicone
Copy link
Contributor Author

vpicone commented Aug 11, 2019

@joshblack not changing the categorization, just the name to match the other 3D icons with the watson health prefix.

Any idea whats up with the ci-check error? The svg file was updated and it's a little vague.

Error: The following icons are missing or an error has occurred:
[
  "3D-iCA"
]

@chrisconnors-ibm
Copy link
Contributor

looks like this just makes an asset name = its references in metadata.yml and categories.yml

only question for @conradennis is, which is it supposed to be: iCA-3D.svg or 3D-iCa.svg?

In my repo the assets is named iCA-3D.svg which I assume is intentional.

@conradennis
Copy link
Contributor

I'm fine with renaming it 3D-iCA, I don't think the order of the name matters so it's probably better to group it with the other 3D named icons

@vpicone
Copy link
Contributor Author

vpicone commented Aug 12, 2019

@chrisconnors-ibm

This came up during the icon library component work. The iCa-3D doesn't follow the naming convention of the other 3D Watson Health icons:

  • 3D-Cursor
  • 3D-curve--auto-colon
  • 3D-curve--auto-vessels
  • 3D-curve--manual
  • 3D-MPR-Toggle

It should also use a more appropriate friendly name, right now it's I ca 3D.

Other Watson Health friendly names:

  • 3D Cursor
  • 3D curve auto colon
  • 3D curve auto vessals
  • 3D curve manual
  • 3D mpr toggle

Copy link
Contributor

@chrisconnors-ibm chrisconnors-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches Objective per conrad "rename it 3D-iCA to group with other 3D icons"

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is failing because the asset name is 3D-iCA instead of 3D-iCa 👍

@vpicone vpicone merged commit a73fcea into carbon-design-system:master Aug 26, 2019
@vpicone vpicone deleted the iCA-3D-metadata branch August 26, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icons]: iCa icon using different naming conventions
5 participants