-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 3D-iCA metadata #3709
fix: 3D-iCA metadata #3709
Conversation
Deploy preview for the-carbon-components ready! Built with commit e333e98 https://deploy-preview-3709--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit e333e98 |
Deploy preview for carbon-components-react failed. Built with commit e333e98 https://app.netlify.com/sites/carbon-components-react/deploys/5d64119fe2d9060007c28deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will defer to chris/conrad on categorization 👍
@joshblack not changing the categorization, just the name to match the other Any idea whats up with the ci-check error? The svg file was updated and it's a little vague. Error: The following icons are missing or an error has occurred:
[
"3D-iCA"
] |
looks like this just makes an asset name = its references in only question for @conradennis is, which is it supposed to be: In my repo the assets is named |
I'm fine with renaming it 3D-iCA, I don't think the order of the name matters so it's probably better to group it with the other 3D named icons |
This came up during the icon library component work. The iCa-3D doesn't follow the naming convention of the other 3D Watson Health icons:
It should also use a more appropriate friendly name, right now it's Other Watson Health friendly names:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this matches Objective per conrad "rename it 3D-iCA to group with other 3D icons"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI is failing because the asset name is 3D-iCA
instead of 3D-iCa
👍
closes #3708