fix: friendly name for 3D components #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Aug 8, 2019
|
Maybe we should use Or could scope as: |
|
@joshblack i wasn’t sure if there are modules that use friendly name programmatically like I am at the moment to get the component/module name. |
|
I think you're good to go either way 👍 |
|
Deploy preview for the-carbon-components ready! Built with commit fb22e52 https://deploy-preview-3691--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit fb22e52 |
|
Deploy preview for carbon-components-react ready! Built with commit fb22e52 https://deploy-preview-3691--carbon-components-react.netlify.com |
dakahn
approved these changes
Aug 8, 2019
|
@joshblack ah I see, gotta remember to scope my initial commit. Wondering if we should force a scope in fix/feat commit messages 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3690