Fix toast notification long text #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 670ab5d https://deploy-preview-2746--the-carbon-components.netlify.com |
|
@imandyie Is this fix applied to inline notifications and would also fix this issue I brought up? |
|
Deploy preview for carbon-components-react ready! Built with commit 670ab5d https://deploy-preview-2746--carbon-components-react.netlify.com |
asudoh
approved these changes
May 15, 2019
There was a problem hiding this comment.
LGTM 👍 once @elizabethsjudd's question is addressed - Thanks @imandyie!
|
@elizabethsjudd this fix is for toast notifications. I could not replicate the issue for inline notifications. |
|
@elizabethsjudd is correct, this issue still happens with inline notifications https://codepen.io/tjegan/pen/NVgRVg
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
