-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Pagination): handle unknown totalItems again #16306
fix(Pagination): handle unknown totalItems again #16306
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really solid improvement, thanks for tackling it! I'm not sure why we didn't do something like this earlier. Your solution here is much better than what I was previously recommending in #9754
I do think a better long-term alternative to not rendering the select would be a number input, #5546
Co-authored-by: Taylor Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
eb5e10f
Closes #16298
a previous PR broke the ability to use pagesUnknown and totalItems. This fixes that and these things:
Changelog
Changed
Testing / Reviewing
New story in storybook
unit test added
send totalItems undefined