fix(tabletoolbarsearch): prefix internally placed id #16232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Apr 23, 2024
alisonjoseph
approved these changes
Apr 24, 2024
Merged
via the queue into
carbon-design-system:main
with commit Apr 25, 2024
7ea3b30
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in slack, the accessibility checker storybook addon has a small bug with
ids that are numbers. Usually when we usesetupGetInstanceIdwe end up prefixing the value with some additional string. This updates TableToolbarSearch's usage ofsetupGetInstanceIdto prefix the value.Changelog
Changed
Testing / Reviewing