Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript types to Stack component #15404

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

mattborghi
Copy link
Contributor

Closes #13577

Add Typescript types to Stack component

Changelog

New

  • Add Typescript types to Stack component

Changed

  • File extensions from .ts to .tsx.

Removed

  • N/A.

Testing / Reviewing

  • Storybook runs as before.
  • Unit tests passing.

@mattborghi mattborghi requested a review from a team as a code owner December 17, 2023 00:38
Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b079272
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/657e42fc88ee040008b736b8
😎 Deploy Preview https://deploy-preview-15404--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@github-actions github-actions bot enabled auto-merge December 20, 2023 14:34
@github-actions github-actions bot added this pull request to the merge queue Dec 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 20, 2023
@guidari guidari added this pull request to the merge queue Dec 20, 2023
Merged via the queue into carbon-design-system:main with commit d177d26 Dec 20, 2023
danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
* refactor: changing file extensions to .tsx for Stack component

* refactor(typescript): add types to Stack component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to Stack, VStack, HStack
3 participants