-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Type pagination #15399
Merged
Merged
feat: Type pagination #15399
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0d615c5
feat: add types to Pagination
Tresau d30eb7c
Merge branch 'main' into type-pagination
Tresau 26d7400
Merge branch 'main' into type-pagination
Tresau db49da2
refactor: update pageSizes proptype to correctly match interface
Tresau defc4fc
test: update public snapshot since proptypes changed
Tresau 8ae0b83
Merge branch 'main' into type-pagination
Tresau 1cf7ebc
Merge branch 'main' into type-pagination
Tresau d03919b
Merge branch 'main' into type-pagination
Tresau 88d7290
Merge branch 'main' into type-pagination
Tresau f8a7ffc
Merge branch 'main' into type-pagination
Tresau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely appreciate this is still a draft, but just to flag in the case it's helpful, based on this (and its display in the docs);
carbon/packages/react/src/components/Pagination/Pagination.tsx
Lines 508 to 516 in d30eb7c
This might need to be a
number