Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(typescript): Add Typescript types to ProgressBar #15346

Merged
merged 4 commits into from
Jan 3, 2024
Merged

refactor(typescript): Add Typescript types to ProgressBar #15346

merged 4 commits into from
Jan 3, 2024

Conversation

mattborghi
Copy link
Contributor

Closes #13570

Add Typescript types to ProgressBar component.

Changelog

New

  • Add Typescript types to ProgressBar component.
  • Add myself as contributor.

Changed

  • File extensions from .js to .tsx.

Removed

  • N/A.

Testing / Reviewing

  • Storybook runs as before.
  • Unit tests passing.

@mattborghi mattborghi requested a review from a team as a code owner December 7, 2023 15:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@mattborghi
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit df38e8c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65945c623082110009d0f2a5
😎 Deploy Preview https://deploy-preview-15346--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreancardona andreancardona self-requested a review January 2, 2024 18:56
andreancardona
andreancardona approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@github-actions github-actions bot enabled auto-merge January 2, 2024 18:57
@github-actions github-actions bot added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 2, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Jan 3, 2024
Merged via the queue into carbon-design-system:main with commit 06befb8 Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@andreancardona andreancardona andreancardona approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to ProgressBar
4 participants
@mattborghi @tw15egan @andreancardona @tay1orjones