Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(time-picker): move label before input it's labelling #1446

Merged
merged 2 commits into from
Nov 16, 2018
Merged

fix(time-picker): move label before input it's labelling #1446

merged 2 commits into from
Nov 16, 2018

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Nov 15, 2018

Closes #1345

The input's label was placed after the form element instead of before. Just a quick fix ✊

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @dakahn!

@joshblack joshblack merged commit 3ed3b09 into carbon-design-system:master Nov 16, 2018
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.53.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♿Time Picker AVT1 - August 2018♿
5 participants