Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Toggle): adds typescript typings to Toggle #14128

Merged
merged 4 commits into from
Jul 5, 2023
Merged

feat(Toggle): adds typescript typings to Toggle #14128

merged 4 commits into from
Jul 5, 2023

Conversation

erifsx
Copy link
Contributor

@erifsx erifsx commented Jun 30, 2023 •
edited
Loading

Closes #12564

Adds typescript typing to the Toggle component

Changelog

New

  • Copies the typings for Tooltip from the definitely typed repo and updates to match current typings.

Changed

  • the jsDoc for useControllableState had onChange as a required field and the jsDoc now types it as optional

Testing / Reviewing

  • should build
  • storybooks should work
  • all existing fields should be accessible from typescript

@erifsx erifsx requested a review from a team as a code owner June 30, 2023 20:10
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@erifsx
Copy link
Contributor Author

erifsx commented Jun 30, 2023

I have read the DCO document and I hereby sign the DCO.

@erifsx
Copy link
Contributor Author

erifsx commented Jun 30, 2023

recheck

@netlify
Copy link

netlify bot commented Jun 30, 2023 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0e7fe96
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64a59ebe91df05000804f2e3
😎 Deploy Preview https://deploy-preview-14128--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 30, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0e7fe96
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64a59ebed9f03d000809c93a
😎 Deploy Preview https://deploy-preview-14128--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

francinelucca
francinelucca suggested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this PR together @erifsx ! mostly LGTM, just one minor change request 🙏🏻.
TIA

@erifsx erifsx requested a review from francinelucca July 3, 2023 12:03
@kodiakhq kodiakhq bot merged commit 90a6610 into carbon-design-system:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@francinelucca francinelucca francinelucca approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to Toggle
3 participants
@erifsx @tay1orjones @francinelucca