Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types/structured list #13632

Merged
merged 11 commits into from
Sep 27, 2023

Conversation

kubijo
Copy link
Contributor

@kubijo kubijo commented Apr 20, 2023

Closes #13538, #13539

Changelog

New

  • add TypeScript types to StructuredList & StructuredListSkeleton

@kubijo kubijo requested a review from a team as a code owner April 20, 2023 10:07
@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b03c36b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6509aacceb9cc700082765f7
😎 Deploy Preview https://deploy-preview-13632--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b03c36b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6509aacdfca2c500087f7c51
😎 Deploy Preview https://deploy-preview-13632--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kubijo kubijo force-pushed the types/StructuredList branch from a68f74d to 6c4ff56 Compare April 21, 2023 11:58
@kubijo kubijo requested a review from a team as a code owner April 21, 2023 11:58
@kubijo kubijo force-pushed the types/StructuredList branch from 6efacfb to 7be4acc Compare May 9, 2023 16:04
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this one. It just needed snapshots updated and a small merge conflict resolved. Sorry for the delay.

@tay1orjones
Copy link
Member

@andreancardona @alisonjoseph bump for review on this one, I got ci to pass

@andreancardona andreancardona added this pull request to the merge queue Sep 27, 2023
Merged via the queue into carbon-design-system:main with commit 52804b0 Sep 27, 2023
@carbon-automation
Copy link
Contributor

Hey there! v11.39.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
4 participants