Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structuredlistinput): call onchange #13625

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Apr 18, 2023

Continuation of #13368

Surfaced on slack

Changelog

Changed

  • Update onChange handler to actually call onChange prop

Testing / Reviewing

  • The onChange prop should be called on change

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 79437f7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64405b969d07760007f4bc8d
😎 Deploy Preview https://deploy-preview-13625--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 79437f7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64405b96616cd70008b67aa6
😎 Deploy Preview https://deploy-preview-13625--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones tay1orjones requested review from andreancardona and removed request for tw15egan April 19, 2023 12:55
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit f68f0fc into carbon-design-system:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants