Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(select): add experimental select #1348

Merged
merged 4 commits into from
Oct 30, 2018
Merged

feat(select): add experimental select #1348

merged 4 commits into from
Oct 30, 2018

Conversation

tw15egan
Copy link
Contributor

Closes #1211

Adds in experimental Select

Changelog

New

  • Experimental Select, Experimental InlineSelect

Changed

Removed

  • Old unnecessary styles

Testing / Reviewing

Will add a staging link once Date Picker styles have been merged in, as this relies on styles from that PR

screen shot 2018-10-26 at 11 07 31 am

@tw15egan tw15egan changed the title Experimental select feat(select): add experimental select Oct 26, 2018
asudoh
asudoh approved these changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

@tw15egan
Copy link
Contributor Author

@aagonzales Staging link is up: http://carbon-dev-environment-exp-select-excellent-giraffe.mybluemix.net/?nav=select

alisonjoseph
alisonjoseph approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once design signs off!

@tw15egan tw15egan mentioned this pull request Oct 30, 2018
Closed
@aagonzales
Copy link
Member

The select is missing the border bottom but besides that looks good 👍 ✅
image

@tw15egan tw15egan force-pushed the experimental-select branch from c58df1c to 21a8883 Compare October 30, 2018 18:48
@tw15egan tw15egan merged commit 77bb2c0 into carbon-design-system:master Oct 30, 2018
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emyarod emyarod mentioned this pull request Feb 8, 2019
Closed
@tw15egan tw15egan deleted the experimental-select branch April 28, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees

@aagonzales aagonzales

Labels
status: one more review 👀 status: ready for review 👀 status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tw15egan @aagonzales @carbon-bot @asudoh @alisonjoseph