Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): make titleText required #13016

Conversation

tay1orjones
Copy link
Member

Closes #12809

Changelog

Changed

  • make titleText required in Dropdown

Testing / Reviewing

  • Make sure the Dropdown stories all render properly and don't give proptype warnings locally

@tay1orjones tay1orjones requested review from a team as code owners January 24, 2023 17:43
@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f972646
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63d1755768461f000a033b84
😎 Deploy Preview https://deploy-preview-13016--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f972646
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63d17557cf6f57000917880b
😎 Deploy Preview https://deploy-preview-13016--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 1d416ab into carbon-design-system:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: Dropdown titleText prop should be marked as required
3 participants