feat(Button): add as prop to IconButton inside of the Button component #12900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
matkrzy
force-pushed
the
feature/button-icon-as-property
branch
from
564abc7 to
74d9c2a
Compare
|
I have read the DCO document and I hereby sign the DCO. |
matkrzy
force-pushed
the
feature/button-icon-as-property
branch
from
74d9c2a to
869c65b
Compare
matkrzy
force-pushed
the
feature/button-icon-as-property
branch
from
869c65b to
4724b09
Compare
tw15egan
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button with flag
hasIconOnlyrenders Button component withoutasprop so we are not able to pass custom render componentChangelog
Changed
asTesting / Reviewing
hasIconOnlyasproperty