fix(ComposedModal): fix focus trap and refocus to trigger element when closed #11418
Conversation
annawen1
requested review from
tay1orjones and
joshblack
and removed request for
a team
| @@ -108,6 +108,10 @@ | |||
| @include breakpoint(xlg) { | |||
| width: 48%; | |||
| } | |||
|
|
|||
| .#{$prefix}--modal-container-body { | |||
There was a problem hiding this comment.
@tay1orjones should the new styles be added to both packages/styles/scss/components/modal/_modal.scss and packages/components/src/components/modal/_modal.scss?
There was a problem hiding this comment.
You may be able to get away with only packages/components in v10 at this point since the styles package is private, curious what you think @tay1orjones 👀 Definitely doesn't hurt having it in both places though (especially if that makes porting things back easier)
There was a problem hiding this comment.
Yeah, same thought. Having the same in both spots is preferred/nice but not necessary.
| @@ -106,6 +106,10 @@ | |||
| @include carbon--breakpoint(xlg) { | |||
| width: 48%; | |||
| } | |||
|
|
|||
| .#{$prefix}--modal-container-body { | |||
| display: contents; | |||
There was a problem hiding this comment.
Just wanted to double-check, do we need to offer any fallbacks for IE11 support or should this work as expected?
There was a problem hiding this comment.
@joshblack oh I didn't think about that, are you guys still supporting IE11? the dotcom team has dropped IE from our supported browser list.
There was a problem hiding this comment.
@annawen1 it shouldn't be a problem in v11 but technically we do still support it for v10. If the file is already using non-IE11 supported features though it's definitely okay to ship as-is which is why I was curious if that was already in place
There was a problem hiding this comment.
Looks good pending the comments from @joshblack 👍
Once merged, does this need to go out in a v10 patch now, or can it wait until our release next week?
@tay1orjones I think we can sit on it till the release next week! |
Closes
Gets changes from #11350 and #11390 into the
v10branch.RPReplay_Final1652723745.mov
Changelog
Changed
aria-hiddenwhen modal is closed to prevent VO from reading out modal content when closedonClosein the ComposedModal storyTesting / Reviewing
test using VO on iOS
State Managerstory to ensure when modal is closed, focus goes back to the "Launch composed modal" button