Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react): update cloud foundry manifest #11345

Merged
merged 2 commits into from
May 5, 2022
Merged

chore(react): update cloud foundry manifest #11345

merged 2 commits into from
May 5, 2022

Conversation

joshblack
Copy link
Contributor

Closes #11343

Changelog

New

Changed

  • Update CF manifest to point to v17 react cloud foundry app

Removed

@joshblack joshblack requested a review from a team as a code owner May 4, 2022 19:55
@joshblack joshblack requested review from jnm2377 and dakahn and removed request for a team May 4, 2022 19:55
tay1orjones
tay1orjones approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest should override any configs provided via the ibmcloud cli, but I pushed a commit updating the workflow to use the proper name just in case.

@kodiakhq kodiakhq bot merged commit ecaf9b3 into v10 May 5, 2022
@kodiakhq kodiakhq bot deleted the joshblack-patch-1 branch May 5, 2022 14:46
This was referenced May 24, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@dakahn dakahn dakahn approved these changes

@jnm2377 jnm2377 Awaiting requested review from jnm2377 jnm2377 was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @tay1orjones @dakahn