Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): cleanup storybook, tweak setup #11316

Merged
merged 8 commits into from
May 4, 2022

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Apr 29, 2022

These are fairly minor tweaks and fixes that I ran into when I was converting this repo over to vite storybook. They can be reviewed/considered apart from any other changes.

I'll fill out the changelog if requested (if there's a chance of merging, basically). Hopefully the commits are atomic enough to make them easy to review.

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

Verify that the storybook still builds in dev and production, and there are no runtime errors.

@IanVS IanVS requested a review from a team as a code owner April 29, 2022 02:57
@IanVS IanVS requested review from aledavila and abbeyhrt April 29, 2022 02:57
@netlify
Copy link

netlify bot commented Apr 29, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 62a3c72
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6272ed6cf9fe550008ce808b
😎 Deploy Preview https://deploy-preview-11316--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 29, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 62a3c72
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6272ed6cbd8ad100082b7124
😎 Deploy Preview https://deploy-preview-11316--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joshblack
Copy link
Contributor

Thanks for taking the time to do this @IanVS! I really appreciate it 🙏

@joshblack
Copy link
Contributor

bump @aledavila @abbeyhrt when you get a sec!

@joshblack joshblack changed the title Storybook cleanup/tweaks docs(react): cleanup storybook, tweak setup May 4, 2022
@kodiakhq kodiakhq bot merged commit 9008f5f into carbon-design-system:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants