Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uishell): header action icon placement and theme #11152

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

tay1orjones
Copy link
Member

Closes #11151

Fixes UIShell header actions to have proper alignment and color/theme values.

Changelog

Changed

  • Removed unnecessary tooltip trigger class that is no longer placed on the actions in v11

Testing / Reviewing

  • All UIShell header stories, including the ones with various actions, should render appropriately in all themes via the storybook theme switcher.

@tay1orjones tay1orjones requested a review from a team as a code owner April 5, 2022 19:37
@tay1orjones tay1orjones requested review from joshblack, jnm2377, a team and aagonzales and removed request for a team April 5, 2022 19:37
@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 0687244
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/624c9a73381c930008873a87
😎 Deploy Preview https://deploy-preview-11152--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0687244
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/624c9a73d823490009ddf20b
😎 Deploy Preview https://deploy-preview-11152--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit ed6eeb1 into carbon-design-system:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: UIShell header actions do not use theme values
5 participants