Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icon-build-helpers]: improve error reporting #6555

Closed
vpicone opened this issue Jul 24, 2020 · 1 comment · Fixed by #6556
Closed

[icon-build-helpers]: improve error reporting #6555

vpicone opened this issue Jul 24, 2020 · 1 comment · Fixed by #6556
Labels
status: needs triage 🕵️‍♀️ status: waiting for maintainer response 💬 type: enhancement 💡

Comments

@vpicone
Copy link
Contributor

vpicone commented Jul 24, 2020

Right now, when validation fails for the icon/pictogram validation, we get the error message but no reference to what asset or which extension caused the error.
@vpicone
Copy link
Contributor Author

vpicone commented Jul 24, 2020

I can take this!

vpicone added a commit to vpicone/carbon that referenced this issue Jul 24, 2020
@vpicone
chore: improve icon builder validation closes carbon-design-system#6555
29357bf
@vpicone vpicone mentioned this issue Jul 24, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #6556 Jul 27, 2020
kodiakhq bot pushed a commit that referenced this issue Jul 27, 2020
@vpicone
chore: improve icon builder validation closes #6555 (#6556)
fa022be 
* chore: improve icon builder validation closes #6555

* chore: update schemas and fix error

* fix: duplicate softlayer--enablement

Co-authored-by: Vince Picone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage 🕵️‍♀️ status: waiting for maintainer response 💬 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improve icon builder validation closes #6555 vpicone/carbon
1 participant
@vpicone