Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Select - add docs about width #200

Closed
tay-aitken opened this issue Jun 23, 2017 · 4 comments
Closed

Inline Select - add docs about width #200

tay-aitken opened this issue Jun 23, 2017 · 4 comments
Assignees

Comments

@tay-aitken
Copy link
Contributor

The caret for inline select should no be that far away from the text. There should be 10px of padding between the two. I realize that it is adjusting for the lengthier option from the dropdown menu (based on a character count I believe) but is there anyway to reduce the space? With that large amount of space it is difficult for people to see the association between the two elements.
screen shot 2017-06-23 at 10 19 25 am

@hellobrian
Copy link
Contributor

Hey @tay-aitken!

Yes, the inline-select is wrapped with a <div> element that can be given a smaller fixed width.
Below are screenshots of what happens when I add width: 250px; to the wrapping <div>.

image
image
image

@hellobrian hellobrian self-assigned this Jun 27, 2017
@tay-aitken
Copy link
Contributor Author

Hey what's up @hellobrian!

Great! Can we add in some documentation then that states that the width of the dropdown select box should be the width of the default placeholder text (whatever text is there before the user makes a selection) + 16px of padding. And whatever option the user selects should truncate down to that size and not change the width of the box. I am only asking that we put that in code, since I don't know how often the devs go to the usage tab.

@hellobrian hellobrian changed the title Inline Select - bug Inline Select - add docs about width Jun 28, 2017
@hellobrian hellobrian removed their assignment Jun 28, 2017
@hellobrian
Copy link
Contributor

We can close this when someone adds docs to carbon-components and the website about this.

@tay-aitken
Copy link
Contributor Author

tay-aitken commented Oct 30, 2017

Assigning myself to update any content to reflect this and adding @marijohannessen and @tw15egan to fix the component itself and reflect the changes in dev documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants