Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI: es6.object.to-string.js 'default' is not exported #148

Closed
hellobrian opened this issue Jun 2, 2017 · 2 comments
Closed

Travis CI: es6.object.to-string.js 'default' is not exported #148

hellobrian opened this issue Jun 2, 2017 · 2 comments

Comments

@hellobrian
Copy link
Contributor

Overview

START:
commonjs-proxy:/home/travis/build/carbon-design-system/carbon-components/node_modules/core-js/library/modules/es6.object.to-string.js (1:219) 'default' is not exported by 'node_modules/core-js/library/modules/es6.object.to-string.js'

☝️ Is anyone aware of why our Travis CI is logging this out before running tests? Not sure how to resolve this myself. cc: @asudoh
@asudoh
Copy link
Contributor

asudoh commented Jun 2, 2017

@hellobrian Good catch, I suspect it's because rollup-plugin-commonjs is not applied to core-js for tests. The roll up config for tests can be found in karma.conf.js. Would you want to fix it? If not let me know and I can go ahead and fix it.

@hellobrian
Copy link
Contributor Author

Hey @asudoh, sorry for the late reply. If it's okay, might be better if you fix it. Thanks for offering!

asudoh added a commit to asudoh/carbon-components that referenced this issue Jun 13, 2017
@asudoh
fix(test): avoid default-not-exported warning from Rollup in test
b6f47cb 
core-js/library/modules/es6.object.to-string.js is a zero-length file, and thus has no default export.

Fixes carbon-design-system#148.
@asudoh asudoh mentioned this issue Jun 13, 2017
Merged
chrisdhanaraj pushed a commit that referenced this issue Jun 21, 2017
@asudoh @chrisdhanaraj
fix(test): avoid default-not-exported warning from Rollup in test (#176)
42144c2 
core-js/library/modules/es6.object.to-string.js is a zero-length file, and thus has no default export.

Fixes #148.
joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@reicruz
Added list of repos that use components, closes carbon-design-system#148
c3051f3 
 (carbon-design-system#230)
joshblack pushed a commit to joshblack/carbon that referenced this issue May 8, 2019
@conradennis @joshblack
feat(icons): add additional icon assets (carbon-design-system#148)
4edd51c 
updates and additions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asudoh @hellobrian