Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: review and finalize error states for components #1390

Closed
aagonzales opened this issue Nov 5, 2018 · 5 comments
Closed

Experimental: review and finalize error states for components #1390

aagonzales opened this issue Nov 5, 2018 · 5 comments
Assignees

Comments

@aagonzales
Copy link
Member

We've had multiple issues with error/validations states in the new Duo system. We need to evaluate and finalize the style across the board.

  • states: enabled, focus, active, hover
  • icon or not icon
  • what happens with small inputs?
  • what happens with multi-line
@aagonzales
Copy link
Member Author

@designertyler If you get bored and want to take a stab this be my guest 😆
Link to components here: https://ibm.box.com/s/wjx23mseagc2air9l50j3p38katmptsk

@designertyler designertyler self-assigned this Nov 9, 2018
@laurenmrice
Copy link
Member

laurenmrice commented Nov 14, 2018

Audit

  • Consistently keep the Red 60, 2px, inside border and error message below.

  • Error message will be getting type style label-01 (12/16, .32)

  • Changed alert icon in progress indicator to error icon.

  • **Still need to figure out whether to keep or omit icon in fields.

  • 2px Border paired with an error message displayed for color blindness is good however, an icon would be an even better visual cue.

  • Having an icon inside a field could cause potential issues for mobile.

  • Aria labels used to identify errors.

  • Will try to finalize this issue in Design review Friday.

Artboard Copy.png

@aagonzales aagonzales removed their assignment Nov 15, 2018
@laurenmrice
Copy link
Member

laurenmrice commented Nov 15, 2018

Exploration

Artboard Copy 2.png

@laurenmrice laurenmrice reopened this Nov 15, 2018
@aagonzales
Copy link
Member Author

Sprint 25: pick final direction and submit dev issue with changes.
@laurenmrice

@designertyler designertyler removed their assignment Dec 4, 2018
@laurenmrice
Copy link
Member

laurenmrice commented Dec 4, 2018

Final error message

Fields:
-Icon within field to the right
-2 px border
-error message below
Artboard Copy.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants