Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to Tab, TabContent, TabList, TabPanel, TabPanels, Tabs #13540

Closed
Tracked by #12513
tay1orjones opened this issue Apr 17, 2023 · 1 comment · Fixed by #13635
Closed
Tracked by #12513

Add TypeScript types to Tab, TabContent, TabList, TabPanel, TabPanels, Tabs #13540

tay1orjones opened this issue Apr 17, 2023 · 1 comment · Fixed by #13635
Assignees
@kubijo @francinelucca
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐

Comments

@tay1orjones
Copy link
Member

No description provided.

@tay1orjones tay1orjones mentioned this issue Apr 17, 2023
Closed
@tay1orjones tay1orjones added status: help wanted 👐 role: dev 🤖 hacktoberfest See https://hacktoberfest.com/ area: typescript needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Apr 17, 2023
@kubijo
Copy link
Contributor

kubijo commented Apr 20, 2023

I'm taking this

kubijo added a commit to kubijo/carbon that referenced this issue Apr 20, 2023
@kubijo
feat(Tabs): rename to tsx carbon-design-system#13540, carbon-design-s…
6c95577 
…ystem#13541
kubijo added a commit to kubijo/carbon that referenced this issue Apr 20, 2023
@kubijo
feat(Tabs): add types carbon-design-system#13540, carbon-design-syste…
2ec41fe 
…m#13541
@kubijo kubijo mentioned this issue Apr 20, 2023
Merged
kubijo added a commit to kubijo/carbon that referenced this issue Apr 21, 2023
@kubijo
feat(Tabs): rename to tsx carbon-design-system#13540, carbon-design-s…
529eb10 
…ystem#13541
kubijo added a commit to kubijo/carbon that referenced this issue Apr 21, 2023
@kubijo
feat(Tabs): add types carbon-design-system#13540, carbon-design-syste…
4fba0cb 
…m#13541
kubijo added a commit to kubijo/carbon that referenced this issue Apr 27, 2023
@kubijo
feat(Tabs): rename to tsx carbon-design-system#13540, carbon-design-s…
50a4aef 
…ystem#13541
kubijo added a commit to kubijo/carbon that referenced this issue Apr 27, 2023
@kubijo
feat(Tabs): add types carbon-design-system#13540, carbon-design-syste…
f300419 
…m#13541
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(Tabs): rename to tsx carbon-design-system#13540, carbon-design-s…
31d7531 
…ystem#13541
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(Tabs): add types carbon-design-system#13540, carbon-design-syste…
366b498 
…m#13541
@kodiakhq kodiakhq bot closed this as completed in #13635 Jun 20, 2023
kodiakhq bot added a commit that referenced this issue Jun 20, 2023
@kubijo @francinelucca @kodiakhq
Types/tabs (#13635)
90ebb84 
* feat(Tabs): rename to tsx #13540, #13541

* feat(Tabs): add types #13540, #13541

* fix(Tabs): add deprecated light prop to interface

* fix(Tabs): re-add default value

* fix: dependency update

---------

Co-authored-by: Francine Lucca <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kubijo kubijo

@francinelucca francinelucca

Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Projects
No open projects
Initial TypeScript Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Types/tabs kubijo/carbon
3 participants
@tay1orjones @kubijo @francinelucca