Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to ExpandableTile #13536

Closed
Tracked by #12513
tay1orjones opened this issue Apr 17, 2023 · 2 comments
Closed
Tracked by #12513

Add TypeScript types to ExpandableTile #13536

tay1orjones opened this issue Apr 17, 2023 · 2 comments
Labels
afrohacks See https://ibm.biz/afrohacks-hackathon area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐

Comments

@tay1orjones
Copy link
Member

No description provided.

@tay1orjones tay1orjones mentioned this issue Apr 17, 2023
Closed
@tay1orjones tay1orjones added status: help wanted 👐 role: dev 🤖 hacktoberfest See https://hacktoberfest.com/ area: typescript needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Apr 17, 2023
@kubijo
Copy link
Contributor

kubijo commented Apr 19, 2023

I'm taking this

kubijo added a commit to kubijo/carbon that referenced this issue Apr 20, 2023
@kubijo
feat(ExpandableTile): rename to tsx carbon-design-system#13536
734fa8a
kubijo added a commit to kubijo/carbon that referenced this issue Apr 20, 2023
@kubijo
feat(ExpandableTile): add types carbon-design-system#13536
a4c3f6a
@kubijo kubijo mentioned this issue Apr 20, 2023
Merged
kubijo added a commit to kubijo/carbon that referenced this issue Apr 20, 2023
@kubijo
feat(ExpandableTile): add types carbon-design-system#13536
69b7d42
kubijo added a commit to kubijo/carbon that referenced this issue Apr 21, 2023
@kubijo
feat(ExpandableTile): rename to tsx carbon-design-system#13536
29e860a
kubijo added a commit to kubijo/carbon that referenced this issue Apr 21, 2023
@kubijo
feat(ExpandableTile): add types carbon-design-system#13536
02baaab
kubijo added a commit to kubijo/carbon that referenced this issue Apr 22, 2023
@kubijo
fix(Tile): remove invalid attr; suppress false lint error carbon-desi…
a3aa3e2 
…gn-system#13536
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(ExpandableTile): rename to tsx carbon-design-system#13536
a5a82fd
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(ExpandableTile): add types carbon-design-system#13536
cf21268
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
fix(Tile): remove invalid attr; suppress false lint error carbon-desi…
8842ea6 
…gn-system#13536
kubijo added a commit to kubijo/carbon that referenced this issue Jun 7, 2023
@kubijo
feat(ExpandableTile): rename to tsx carbon-design-system#13536
c3bc50d
kubijo added a commit to kubijo/carbon that referenced this issue Jun 7, 2023
@kubijo
feat(ExpandableTile): add types carbon-design-system#13536
430ae86
kubijo added a commit to kubijo/carbon that referenced this issue Jun 7, 2023
@kubijo
fix(Tile): remove invalid attr; suppress false lint error carbon-desi…
f9a40ea 
…gn-system#13536
kubijo added a commit to kubijo/carbon that referenced this issue Jun 9, 2023
@kubijo
feat(ExpandableTile): rename to tsx carbon-design-system#13536
d9f063a
kubijo added a commit to kubijo/carbon that referenced this issue Jun 9, 2023
@kubijo
feat(ExpandableTile): add types carbon-design-system#13536
0ede3a5
kubijo added a commit to kubijo/carbon that referenced this issue Jun 9, 2023
@kubijo
fix(Tile): remove invalid attr; suppress false lint error carbon-desi…
53d57c7 
…gn-system#13536
kubijo added a commit to kubijo/carbon that referenced this issue Jun 12, 2023
@kubijo
feat(ExpandableTile): rename to tsx carbon-design-system#13536
c80cd76
kubijo added a commit to kubijo/carbon that referenced this issue Jun 12, 2023
@kubijo
feat(ExpandableTile): add types carbon-design-system#13536
55a1ddc
kubijo added a commit to kubijo/carbon that referenced this issue Jun 12, 2023
@kubijo
fix(Tile): remove invalid attr; suppress false lint error carbon-desi…
ddf888c 
…gn-system#13536
kodiakhq bot pushed a commit that referenced this issue Jun 16, 2023
@kubijo @francinelucca
Add TypeScript types to the xTile family of components #13536 (#13631)
fbdc9b5 
* feat(ExpandableTile): rename to tsx #13536

* feat(ExpandableTile): add types #13536

* fix(Tile): remove invalid attr; suppress false lint error #13536

* chore(Tile): address code review comments

* chore(Tile): address review comments & errors

---------

Co-authored-by: Francine Lucca <[email protected]>
@tay1orjones tay1orjones added the afrohacks See https://ibm.biz/afrohacks-hackathon label Oct 30, 2023
@Tresau
Copy link
Contributor

Tresau commented Oct 30, 2023 •
edited
Loading

@tay1orjones looks like this was meant to be closed in PR #13631 however was not. Possibly because the items were listed in a list after closes rather than having the closes keyword for each issue it addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
afrohacks See https://ibm.biz/afrohacks-hackathon area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Projects
No open projects
Initial TypeScript Support
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tay1orjones @kubijo @Tresau