Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: (ComposedModal) port mousedown changes from pr #3014 #10354

Closed
2 tasks done
dakahn opened this issue Jan 6, 2022 · 0 comments · Fixed by #13140
Closed
2 tasks done

[Bug]: (ComposedModal) port mousedown changes from pr #3014 #10354

dakahn opened this issue Jan 6, 2022 · 0 comments · Fixed by #13140
Labels
component: modal good first issue 👋 Used by GitHub to elevate contribution opportunities package: @carbon/react @carbon/react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@dakahn
Copy link
Contributor

dakahn commented Jan 6, 2022

Package

carbon-components-react

Browser

No response

Package version

latest

React version

latest

Description

recently got some bug reports in around mousedown with ComposedModal. Seems like we addressed this bug previously, but only with Modal. So we should port over those changes

ComposedModal changes
#3014

Bug report
#2968 (comment)

CodeSandbox example

na

Steps to reproduce

na

Code of Conduct
@jnm2377 jnm2377 added good first issue 👋 Used by GitHub to elevate contribution opportunities package: @carbon/react @carbon/react labels Aug 15, 2022
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Dec 12, 2022
@tay1orjones tay1orjones added the severity: 3 https://ibm.biz/carbon-severity label Dec 12, 2022
@kcprevatt kcprevatt mentioned this issue Feb 13, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #13140 Feb 15, 2023
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Feb 15, 2023
kennylam added a commit to kennylam/carbon that referenced this issue Jul 30, 2024
@IgnacioBecerra @kennylam
docs(storybook): synced with-layer stories with redesign (carbon-desi…
8735972 
…gn-system#10354)

* docs(storybook): synced with-layer stories with redesign

* fix(tile): set width to expandable story

* fix(with-layers): ensured single element needed

* fix(layers): updated comment

* fix(storybook): addressed comments

---------

Co-authored-by: kennylam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: modal good first issue 👋 Used by GitHub to elevate contribution opportunities package: @carbon/react @carbon/react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ComposedModal): port mousedown changes from pr #3014 kcprevatt/carbon
5 participants
@tay1orjones @joshblack @abbeyhrt @jnm2377 @dakahn