Merge remote-tracking branch 'upstream/release/v1.53.0'

carbon-design-system · Nov 15, 2023 · 6dc80a0 · 6dc80a0
2 parents 6158a36 + 44142f3
commit 6dc80a0
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 17 deletions.
diff --git a/web-components/packages/carbon-web-components/CHANGELOG.md b/web-components/packages/carbon-web-components/CHANGELOG.md
@@ -3,6 +3,35 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.34.0](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/compare/@carbon/[email protected]...@carbon/[email protected]) (2023-11-15)
+
+**Note:** Version bump only for package @carbon/web-components
+
+
+
+
+
+# [1.34.0-rc.2](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/compare/@carbon/[email protected]...@carbon/[email protected]) (2023-11-06)
+
+**Note:** Version bump only for package @carbon/web-components
+
+
+
+
+
+# [1.34.0-rc.1](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/compare/@carbon/[email protected]...@carbon/[email protected]) (2023-11-02)
+
+
+### Bug Fixes
+
+* **language-selector:** remove internal decorator ([#11069](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/11069)) ([d61199d](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/commit/d61199d5c9e03671aa08f9a0b774f470900dfd0c)), closes [#10885](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/10885)
+* **link-with-icon:** refactor LINK_SIZE enum ([#11071](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/11071)) ([cf570e1](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/commit/cf570e15079f8fc58c8b2600848d0c1a87e9b065))
+* **ui-shell:** a11y issue with side nav item ([#11044](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/11044)) ([9eb94ea](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/commit/9eb94ea097dcf9610a72900468008373cfec3bbe)), closes [#10918](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/10918)
+
+
+
+
+
 # [1.34.0-rc.0](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/compare/@carbon/[email protected]...@carbon/[email protected]) (2023-10-30)
 
 

diff --git a/web-components/packages/carbon-web-components/package.json b/web-components/packages/carbon-web-components/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@carbon/web-components",
-  "version": "1.34.0-rc.0",
+  "version": "1.34.0",
   "publishConfig": {
     "access": "public"
   },

diff --git a/web-components/packages/carbon-web-components/src/components/link/link.ts b/web-components/packages/carbon-web-components/src/components/link/link.ts
@@ -20,22 +20,14 @@ const { prefix } = settings;
 /**
  * Link size.
  */
-export enum LINK_SIZE {
-  /**
-   * Regular size
-   */
-  REGULAR = '',
-
-  /**
-   * Small size.
-   */
-  SMALL = 'sm',
+export const LINK_SIZE = {
+  REGULAR: '',
+  SMALL: 'sm',
+  LARGE: 'lg',
+};
 
-  /**
-   * Large size.
-   */
-  LARGE = 'lg',
-}
+// Convert object key in a type
+type LINK_SIZE_TYPE = (typeof LINK_SIZE)[keyof typeof LINK_SIZE];
 
 /**
  * Link.
@@ -190,7 +182,7 @@ class BXLink extends FocusMixin(LitElement) {
    * Link size.
    */
   @property({ reflect: true })
-  size = LINK_SIZE.REGULAR;
+  size: LINK_SIZE_TYPE = LINK_SIZE.REGULAR;
 
   /**
    * The link target.