Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

docs(storybook): update storybook docs with code samples #911

Merged
merged 6 commits into from
Dec 28, 2021
Merged

docs(storybook): update storybook docs with code samples #911

merged 6 commits into from
Dec 28, 2021

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Dec 22, 2021 •
edited
Loading

Related Ticket(s)

[Component README]: Update documentation to include component markup examples #755

Description

Update the component READMEs to include implementation guidelines, sample code, and remove the canvas component.

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • {{removed thing}}

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 22, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/911/index.html

Built with commit: 9fe36294c10c971cc5d518a84e1a3a7796b089c5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 23, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/911/index.html

Built with commit: 901b09cfd62fa5520f7d82787003fb5d65d20e37

ariellalgilmore
ariellalgilmore approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! a lot cleaner now!

@annawen1 annawen1 marked this pull request as ready for review December 28, 2021 14:46
@annawen1 annawen1 requested a review from a team as a code owner December 28, 2021 14:46
@annawen1 annawen1 requested review from emyarod, IgnacioBecerra and JBrandwine and removed request for a team December 28, 2021 14:46
@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Dec 28, 2021
@annawen1 annawen1 added Ready to merge Label for the pull requests that are ready to merge and removed Ready to merge Label for the pull requests that are ready to merge labels Dec 28, 2021
@kodiakhq kodiakhq bot merged commit fdf223b into carbon-design-system:main Dec 28, 2021
@annawen1 annawen1 deleted the docs/storybook-update-docs branch December 28, 2021 16:59
@emyarod emyarod mentioned this pull request Feb 2, 2022
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@JBrandwine JBrandwine Awaiting requested review from JBrandwine JBrandwine is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annawen1 @ibmdotcom-bot @ariellalgilmore