chore(charts): upgrade carbon charts to get the latest version #1566
Conversation
scottdickerson
requested review from
blechner,
bryancboyd,
cgirani,
davidicus,
jessieyan,
JoelArmendariz,
leetosc,
sstone2423,
stuckless,
tay1orjones and
tomklapiscak
as code owners
|
Deploy preview for carbon-addons-iot-react ready! Built with commit 6c6fb2d https://deploy-preview-1566--carbon-addons-iot-react.netlify.app |
| "resolutions": { | ||
| "chokidar": "3.3.1" | ||
| }, |
There was a problem hiding this comment.
Is this related to the node 12/catalina crashes w/ webpack? webpack/watchpack#130 (comment)
I'm still on Mojave so I haven't ran into it (yet). Hopefully we can remove in the future if/when webpack 5 is released and storybook upgrades to use it instead of v4
❯ yarn why chokidar
yarn why v1.12.3
[1/4] 🤔 Why do we have the module "chokidar"...?
[2/4] 🚚 Initialising dependency graph...
warning Resolution field "[email protected]" is incompatible with requested version "chokidar@^2.0.4"
warning Resolution field "[email protected]" is incompatible with requested version "chokidar@^2.0.2"
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
- "webpack#watchpack" depends on it
- Hoisted from "webpack#watchpack#chokidar"
- Hoisted from "@storybook#react#react-dev-utils#fork-ts-checker-webpack-plugin#chokidar"
info Disk size without dependencies: "160KB"
info Disk size with unique dependencies: "464KB"
info Disk size with transitive dependencies: "5.68MB"
info Number of shared dependencies: 49
✨ Done in 1.20s.
There was a problem hiding this comment.
yes exactly, @tay1orjones i thought it was low risk as it only impacts the development, not the runtime so squeezed that in to, apologies I forgot to mention it in the PR details
|
🎉 This PR is included in version 2.114.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #1522
Summary
Acceptance Test (how to verify the PR)