Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check target for Unix-like environment #763

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Fix check target for Unix-like environment #763

merged 1 commit into from
Sep 7, 2016

Conversation

akihikodaki
Copy link
Contributor

No description provided.

@aquynh
Copy link
Collaborator

aquynh commented Sep 3, 2016

does this fixes something? i can see you are refactoring code, but not sure if it fixes any issues.

@akihikodaki
Copy link
Contributor Author

  • Install library to lib$(LIBNAME).$(VERSION_EXT) because install_name specifies so
  • Add LD_LIBRARY_PATH

@aquynh
Copy link
Collaborator

aquynh commented Sep 3, 2016 via email

@akihikodaki
Copy link
Contributor Author

All test linked dynamically fails if capstone is not installed. Otherwise it will use library installed to the system.

@aquynh aquynh mentioned this pull request Sep 3, 2016
Merged
@aquynh aquynh merged commit 5c04e4c into capstone-engine:master Sep 7, 2016
@aquynh
Copy link
Collaborator

aquynh commented Sep 7, 2016

merged, thanks!

could you please send a pull req for the next branch, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akihikodaki @aquynh