Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe a missing crate core #187

Closed
drahnr opened this issue Jun 11, 2020 · 3 comments
Closed

maybe a missing crate core #187

drahnr opened this issue Jun 11, 2020 · 3 comments

Comments

@drahnr
Copy link

drahnr commented Jun 11, 2020

Upgrading from 0.12 to 0.13 causes the following (unsettling errors, core should always always be available):

# rustc --version
rustc 1.44.0 (49cae5576 2020-06-01)`
error[E0433]: failed to resolve: maybe a missing crate `core`?
    --> /media/supersonic1t/projects/spearow/juice/target/release/build/juice-4ee9b139a8580f85/out/juice_capnp.rs:2760:91
     |
2760 |     fn get_from_pointer(builder: ::capnp::private::layout::PointerBuilder<'a>, default: ::core::option::Option<&'a [capnp::Word]>) -> ::capnp::Result<Builder<'a,>> {
     |                                                                                           ^^^^ maybe a missing crate `core`?

https://github.com/spearow/juice/pull/97/files#diff-fc04e529186c96cc603c2d379ce63b7dR32


Steps to reproduce (as in PR fff-rs/juice#97 ):

git clone --branch drahnr-features-tags-and-releases [email protected]:spearow/juice.git juice
cd juice
cargo b --no-default-features --features=native

assuming you have sd installed

sd '=\s*"0.13"' '= "0.12"' ./juice/Cargo.toml

will make compilation work again. Let me know if you need any further information.

drahnr added a commit to fff-rs/juice that referenced this issue Jun 11, 2020
See capnproto/capnproto-rust#187 for the issue
we face once moving to 0.13 .
drahnr added a commit to fff-rs/juice that referenced this issue Jun 11, 2020
See capnproto/capnproto-rust#187 for the issue
we face once moving to 0.13 .
@dwrensha
Copy link
Member

Does it work if you add extern crate core; at the top of your crate?

I think that's necessary in Rust 2015, but not in Rust 2018. (So another way to avoid these errors would be to add edition = "2018" to your Cargo.toml.)

@drahnr
Copy link
Author

drahnr commented Jun 11, 2020

Frankly, I forgot about the limitations of 2015 - thanks! I had the 2018 migration on my TODO anyways, if that does not solve it, I will re-open this. Thanks!

@drahnr drahnr closed this as completed Jun 11, 2020
@drahnr
Copy link
Author

drahnr commented Jun 11, 2020

Did the trick, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants