Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setUserId accept null too #49 #50

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

markxoe
Copy link

@markxoe markxoe commented Feb 16, 2021

I've solved #49 so that null will be accepted by setUserId and in the web-version it gets converted to an empty string

@MNorgren
Copy link

Any update on this PR? I am also waiting on this fix

@brownoxford
Copy link
Member

I have some time set aside later this week for this.

@edouardruiz
Copy link

Hi, I also need to unset the userId via setUserId. @brownoxford do you think you need help to merge this PR?

@sergeivoroshilov
Copy link

@brownoxford @edouardruiz any updates?

@sneko
Copy link

sneko commented May 23, 2022

Also interested by this. Any news @brownoxford?

@sneko
Copy link

sneko commented May 23, 2022

@markxoe it seems your PR is not fixing the issue unfortunately. For example on iOS:

if let userId = call.getString("userId") {
Analytics.setUserID(userId)
call.resolve()
} else {
call.reject("userId property is missing")

Since it expects a "string" it will raise an error in all cases. Did you test your implementation? (maybe I'm doing something wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants