Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Binary columns now return as Buffer for HANAService #689

Merged
merged 8 commits into from
Jun 17, 2024
Merged

fix: Binary columns now return as Buffer for HANAService #689

merged 8 commits into from
Jun 17, 2024

Conversation

BobdenOs
Copy link
Contributor

No description provided.

@BobdenOs BobdenOs requested a review from sjvans June 14, 2024 07:44
sjvans
sjvans approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@sjvans sjvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BobdenOs BobdenOs enabled auto-merge (squash) June 14, 2024 12:49
@BobdenOs BobdenOs added the next release pr to be checked for next release label Jun 14, 2024
danjoa
danjoa approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@danjoa danjoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did they return before?

@BobdenOs
Copy link
Contributor Author

What did they return before?

The binary type columns where accidentally returned as Readable as they where being confused a LOB

@BobdenOs BobdenOs merged commit 179bd92 into main Jun 17, 2024
4 checks passed
@BobdenOs BobdenOs deleted the hana/fix-binary-type branch June 17, 2024 14:03
@cap-bots cap-bots mentioned this pull request Jun 17, 2024
Merged
johannes-vogel added a commit that referenced this pull request Jun 19, 2024
@cap-bots @johannes-vogel
chore: release main (#670)
8be3c7d 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.10.1</summary>

##
[1.10.1](db-service-v1.10.0...db-service-v1.10.1)
(2024-06-19)


### Fixed

* Only check first row if no changes required
([#552](#552))
([39b0b85](39b0b85))
</details>

<details><summary>sqlite: 1.7.2</summary>

##
[1.7.2](sqlite-v1.7.1...sqlite-v1.7.2)
(2024-06-19)


### Fixed

* **deps:** update dependency better-sqlite3 to v11
([#669](#669))
([7167ec5](7167ec5))
</details>

<details><summary>hana: 1.0.0</summary>

##
[1.0.0](hana-v0.5.0...hana-v1.0.0)
(2024-06-19)


### Fixed

* Binary columns now return as Buffer for HANAService
([#689](#689))
([179bd92](179bd92))
* Improve error message for disconnected connections
([#678](#678))
([eb4ef37](eb4ef37))
* insertion of arrayed elements
([#677](#677))
([92cf307](92cf307))
* insertion of large decimals
([#686](#686))
([ae8abff](ae8abff))
* Support static conditions inside unmanaged associations
([#682](#682))
([e17ddfd](e17ddfd))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Johannes Vogel <[email protected]>
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjoa danjoa danjoa approved these changes

@sjvans sjvans sjvans approved these changes

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@stewsk stewsk Awaiting requested review from stewsk stewsk is a code owner

@patricebender patricebender Awaiting requested review from patricebender patricebender is a code owner

Assignees
No one assigned
Labels
next release pr to be checked for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobdenOs @danjoa @sjvans