Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(infer): consolidate two main functions #617

Merged
merged 11 commits into from
May 10, 2024
Merged

refactor(infer): consolidate two main functions #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
086f6a5
chore: consolidate infer function
patricebender Apr 24, 2024
577ad31
fix cqn4sql tests
patricebender Apr 24, 2024
9fd692d
all tests run
patricebender Apr 25, 2024
aec9f09
wip: remove attachRefLinks
patricebender Apr 30, 2024
d3283c9
all my tests run
patricebender Apr 30, 2024
8067622
remove attachRefLinksToArg
patricebender Apr 30, 2024
0cdf3cb
better js doc + new function name
patricebender Apr 30, 2024
a7952ac
add some more docu
patricebender Apr 30, 2024
f19776e
remove side effect function
patricebender Apr 30, 2024
a8ee76d
make target property configurable
patricebender Apr 30, 2024
383751d
Merge remote-tracking branch 'origin/main' into patrice/refactor-infer
patricebender May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db-service/lib/cqn4sql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,7 +1664,7 @@ function cqn4sql(originalQuery, model) {
transformedFrom.$refLinks.splice(0, transformedFrom.$refLinks.length - 1)

let args = from.ref.at(-1).args
const subquerySource = transformedFrom.$refLinks[0].target
const subquerySource = getDefinition(transformedFrom.$refLinks[0].definition.target) || transformedFrom.$refLinks[0].target
if (subquerySource.params && !args) args = {}
const id = localized(subquerySource)
transformedFrom.ref = [args ? { id, args } : id]
Expand Down
Loading