Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list inside path expression #428

Closed
wants to merge 5 commits into from
Closed

Conversation

larslutz96
Copy link
Contributor

related to deep delete

@BobdenOs BobdenOs changed the title fix reflinks for list in where in ref fix: list inside path expression Jan 30, 2024
})
let response
try {
response = cqn4sql(select, model)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the proper expect API when testing for errors. (example)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we need to support that in general?
From my point of view, the from clause is more of a URL representation that does not allow for subselects.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required to delete the compositions that exist on the table, but this is not possible when doing it directly on the view. As they might be removed and therefor having them in the path expression would fail in cqn4sql.

So the idea is to map the root entries that have to be deleted from the table by using the sub select. While still using the path expression logic of cqn4sql to make the follow up compositions deletes.

patricebender added a commit that referenced this pull request Jan 30, 2024
patricebender added a commit that referenced this pull request Jan 31, 2024
@larslutz96 larslutz96 closed this Feb 6, 2024
@patricebender patricebender deleted the fix-reflinks-for-list branch May 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants