fix(hana): ensure the database connection does not enable auto commit (…

…#448)
cap-js · Feb 12, 2024 · b2ca1da · b2ca1da
1 parent 22e1c43
commit b2ca1da
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/hana/lib/HANAService.js b/hana/lib/HANAService.js
@@ -971,7 +971,10 @@ class HANAService extends SQLService {
     return super.onPlainSQL(req, next)
   }
 
-  onBEGIN() { }
+  onBEGIN() {
+    DEBUG?.('BEGIN')
+    return this.dbc?.begin()
+  }
 
   onCOMMIT() {
     DEBUG?.('COMMIT')

diff --git a/hana/lib/drivers/base.js b/hana/lib/drivers/base.js
@@ -95,6 +95,13 @@ class HANADriver {
     throw new Error('Implementation missing "set"')
   }
 
+  /**
+   * Starts a new transaction
+   */
+  async begin() {
+    this._native.setAutoCommit(false)
+  }
+
   /**
    * Commits the current transaction
    */