Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIDAPP-423]: Introduce bulk service request action to add a request update #396

Merged
merged 4 commits into from
Feb 3, 2025
Merged

[AIDAPP-423]: Introduce bulk service request action to add a request update #396

merged 4 commits into from
Feb 3, 2025

Conversation

jayushi-canyon
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

Introduce bulk service request action to add service request update.

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No

Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

@jayushi-canyon jayushi-canyon added the Change Type | New Feature New feature or request label Jan 22, 2025
@jayushi-canyon jayushi-canyon force-pushed the feature/AIDAPP-423 branch 2 times, most recently from 5a4a049 to 74d71ea Compare January 23, 2025 09:07
@jayushi-canyon jayushi-canyon marked this pull request as ready for review January 23, 2025 11:41
@jayushi-canyon jayushi-canyon requested a review from a team as a code owner January 23, 2025 11:41
Orrison
Orrison requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for this bulk action testing all the difference scenarios where an items would be updated or not.

.../src/Filament/Resources/ServiceRequestResource/Actions/AddServiceRequestUpdateBulkAction.php Outdated Show resolved Hide resolved
@jayushi-canyon jayushi-canyon force-pushed the feature/AIDAPP-423 branch 2 times, most recently from 05749e0 to 579777e Compare January 30, 2025 17:59
@Orrison Orrison added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 80e8ed9 Feb 3, 2025
5 checks passed
@Orrison Orrison deleted the feature/AIDAPP-423 branch February 3, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orrison Orrison Orrison approved these changes

Assignees
No one assigned
Labels
Change Type | New Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayushi-canyon @Orrison