fix: starbase breakage from #265 (#270)

* fix: broken shell escaping * fix: improper shell escaping and missed alias * Update Makefile Co-authored-by: Alex Lowe <[email protected]> --------- Co-authored-by: Alex Lowe <[email protected]>
canonical · Oct 11, 2024 · 9027b2c · 9027b2c
1 parent 44ce081
commit 9027b2c
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/Makefile b/Makefile
@@ -38,11 +38,11 @@ help: ## Show this help.
 setup: ## Set up a development environment
 ifeq ($(OS),Linux)
 	changes="`sudo snap install --no-wait codespell`"
-	changes="${changes} `sudo snap install --no-wait ruff`"
-	changes="${changes} `sudo snap install --no-wait shellcheck`"
-	changes="${changes} `sudo snap install --classic --no-wait astral-uv`"
-	for change in ${changes}; do
-		snap watch ${change}
+	changes="$$changes `sudo snap install --no-wait ruff`"
+	changes="$$changes `sudo snap install --no-wait shellcheck`"
+	changes="$$changes `sudo snap install --classic --no-wait astral-uv`"
+	for change in $$changes; do
+		snap watch $$change
 	done
 else ifeq ($(OS),Windows_NT)
 	pipx install uv
@@ -66,21 +66,24 @@ endif
 
 ---------------- : ## ----------------
 
-.PHONY: autoformat
-autoformat: format-ruff format-codespell  ## Run all automatic formatters
+.PHONY: format
+format: format-ruff format-codespell  ## Run all automatic formatters
 
 .PHONY: format-ruff
 format-ruff:  ##- Automatically format with ruff
 	ruff check --fix $(SOURCES)
 	success=true
 	ruff check --fix $(SOURCES) || success=false
 	ruff format $(SOURCES)
-	$success || exit 1
+	$$success || exit 1
 
 .PHONY: format-codespell
 format-codespell:  ##- Fix spelling issues with codespell
 	uv run codespell --toml pyproject.toml --write-changes $(SOURCES)
 
+.PHONY: autoformat
+autoformat: format  # Alias for 'format'
+
 ---------------- : ## ----------------
 
 .PHONY: lint