Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ops 2.17.1 in the mock charm #438

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: use ops 2.17.1 in the mock charm #438

merged 1 commit into from
Feb 10, 2025

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Feb 7, 2025

Description

Install hook in the mock charm is failing to find scenario.runtime which is imported from ops.
This causes failure in integration tests.
The scenario.runtime library relies on ops==2.17.x.
Latest version of ops have breaking changes that make these libraries incompatible.

As a workaround we need to pin the ops version until incompatibilities are solved in the dependent projects.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner February 7, 2025 21:34
@gatici gatici changed the title fix: use ops 2.17.0 in mock charm fix: use ops 2.17.0 in the mock charm Feb 7, 2025
@gatici gatici changed the title fix: use ops 2.17.0 in the mock charm fix: use ops 2.17.1 in the mock charm Feb 7, 2025
@gatici gatici merged commit 5b6ae85 into main Feb 10, 2025
19 checks passed
@gatici gatici deleted the fix-integration-tests branch February 10, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants