Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Expose swagger API at the right URL #435

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix: Expose swagger API at the right URL #435

merged 2 commits into from
Feb 5, 2025

Conversation

ghislainbourgeois
Copy link
Contributor

Description

The URL of the swagger API documentation was not set properly when the application is behind Traefik. This updates the Pebble layer to configure it properly based on the content of the ingress relation.

Fixes canonical/sdcore-nms#715

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner February 4, 2025 17:07
patriciareinoso
patriciareinoso reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@patriciareinoso patriciareinoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just a small comment added

tests/unit/test_charm_configure.py Outdated Show resolved Hide resolved
Gmerold
Gmerold approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @patriciareinoso comment

gatici
gatici approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghislainbourgeois ghislainbourgeois merged commit 53037dd into main Feb 5, 2025
16 checks passed
@ghislainbourgeois ghislainbourgeois deleted the fix-swagger branch February 5, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriciareinoso patriciareinoso patriciareinoso approved these changes

@gatici gatici gatici approved these changes

@Gmerold Gmerold Gmerold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swagger API not working - TLS handshake error
4 participants
@ghislainbourgeois @patriciareinoso @gatici @Gmerold