[MISC] Update libs #480
Merged
[MISC] Update libs #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragomirp
commented
Feb 5, 2025
•
dragomirp
commented
- Update charm libs
- Deploy subordinates with 0 units instead of None
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 75.20% 75.20%
=======================================
Files 9 9
Lines 1319 1319
Branches 239 239
=======================================
Hits 992 992
Misses 254 254
Partials 73 73 ☔ View full report in Codecov by Sentry. |
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
lucasgameiroborges
and removed request for
a team
marceloneppel
approved these changes
Feb 7, 2025
dragomirp
commented
Feb 12, 2025
| @@ -44,7 +44,7 @@ async def test_deploy_and_relate(ops_test: OpsTest, charm): | |||
| ops_test.model.deploy( | |||
| charm, | |||
| application_name=PGB, | |||
| num_units=None, | |||
| num_units=0, | |||
There was a problem hiding this comment.
Started failing on upgrades/ci migration. e.g. https://github.com/canonical/pgbouncer-operator/actions/runs/13272327851/job/37091205687?pr=487#step:7:1552
taurus-forever
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.