Sync configs between units #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dpe-4595-slow-config #258 +/- ##
========================================================
+ Coverage 70.31% 70.79% +0.48%
========================================================
Files 7 7
Lines 1179 1178 -1
Branches 212 209 -3
========================================================
+ Hits 829 834 +5
+ Misses 273 268 -5
+ Partials 77 76 -1 ☔ View full report in Codecov by Sentry. |
src/relations/peers.py
Outdated
| self.charm.render_pgb_config(reload_pgbouncer=True) | ||
| self.unit_databag["readonly_dbs"] = readonly_dbs_hash |
There was a problem hiding this comment.
Is the hash for readonly_dbs needed? I don't see it when checking for hashes on src/relations/pgbouncer_provider.py.
There was a problem hiding this comment.
At the moment, not really. I was thinking of only reloading when content changes, but we'll need to keep track of the auth file secret as well and reloading the service should be cheap. I'll remove it for now.
marceloneppel
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution