[MISC] Await config change #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
added
the
not bug or enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage 70.21% 70.21%
=======================================
Files 9 9
Lines 1353 1353
Branches 224 224
=======================================
Hits 950 950
Misses 315 315
Partials 88 88 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Feb 19, 2025
Comment on lines
+99
to
+100
| for attempt in Retrying(stop=stop_after_delay(30), wait=wait_fixed(3), reraise=True): | ||
| with attempt: |
There was a problem hiding this comment.
Sometimes timesout on juju 2 e.g. https://github.com/canonical/pgbouncer-k8s-operator/actions/runs/13412283538/job/37465375338
dragomirp
requested review from
a team,
taurus-forever and
marceloneppel
and removed request for
a team
marceloneppel
approved these changes
Feb 19, 2025
taurus-forever
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Await config change during data integrator upgrade test