-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spread tests for tutorial #39
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 1710 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
12 | 7 | 1691 | 0 |
Click to see the invalid file list
- charm/src-docs/Makefile
- charm/src-docs/conf.py
- charm/src-docs/make.bat
- charm/src-docs/tutorial/code/getting-started/task.yaml
- charm/tests/spread/lib/cloud-config.yaml
- charm/tests/spread/lib/test-helpers.sh
- charm/tests/spread/lib/tools/retry
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the use of markdown instead of rst and it seems that we can include the code anyway so perhaps we use markdown at least in our docs?
I think if everything is displayed correctly in discourse (pending to see), we can use this for all our charms. |
Test coverage for 9deb09f
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the tutorial and adding a spread test! The documentation changes look good to me 👍
(Not giving an official approval since code was also changed in this PR.)
Overview
This PR creates a testable tutorial, in a similar fashion as it is done in
rockcraft
andcharmcraft
, usingspread
andsphinx
. For that, it uses two plugins insphinx
, one to parse Markdown and one to build into Markdown, so it should work with discourse.The tutorial had to be adapted to use env variables instead of just place holders. The scripts used were copied from the project charmcraft.
As
src-docs
is not used in NetBox (as the code is really inpaas-charm
), thesrc-docs
directory was reused for it.Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)