[cli] rename copy-files to transfer (Fixes #748)
#778
Conversation
Saviq
force-pushed
the
rename-copy-transfer
branch
2 times, most recently
from
c9cd6ed to
b1cdf96
Compare
| return QStringLiteral("Transfer files between the host and instances"); | ||
| } | ||
|
|
||
| QString cmd::Transfer::description() const | ||
| { | ||
| // TODO: Don't mention directories until we support that | ||
| // return QStringLiteral("Copy files and directories between the host and instances."); | ||
| return QStringLiteral("Copy files between the host and instances."); |
There was a problem hiding this comment.
Good choice leaving this as is (clarifies what is meant by transfer).
| { | ||
| return QStringLiteral("Copy files between the host and instances"); | ||
| return {name(), "copy-files"}; |
There was a problem hiding this comment.
I notice this is not reflected in the help, so the alias is hidden. Is that intended?
There was a problem hiding this comment.
Yes, we've just left it here for muscle-memory purposes.
Saviq
force-pushed
the
rename-copy-transfer
branch
from
b1cdf96 to
f47b38c
Compare
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
=========================================
+ Coverage 67.59% 67.6% +0.01%
=========================================
Files 176 176
Lines 6171 6173 +2
=========================================
+ Hits 4171 4173 +2
Misses 2000 2000
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
=========================================
+ Coverage 67.59% 67.6% +0.01%
=========================================
Files 176 176
Lines 6171 6173 +2
=========================================
+ Hits 4171 4173 +2
Misses 2000 2000
Continue to review full report at Codecov.
|
| { | ||
| return QStringLiteral("Copy files between the host and instances"); | ||
| return {name(), "copy-files"}; |
There was a problem hiding this comment.
Yes, we've just left it here for muscle-memory purposes.
Saviq
force-pushed
the
rename-copy-transfer
branch
from
f47b38c to
a0c9bb8
Compare
778: [cli] rename `copy-files` to `transfer` (Fixes #748) r=ricab a=Saviq Co-authored-by: Michał Sawicz <[email protected]> Co-authored-by: Ricardo Abreu <[email protected]>
Build failed |
778: [cli] rename `copy-files` to `transfer` (Fixes #748) r=ricab a=Saviq Co-authored-by: Michał Sawicz <[email protected]> Co-authored-by: Ricardo Abreu <[email protected]>
Build succeeded |
No description provided.